<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Verdana;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Aptos;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:12.0pt;
font-family:"Aptos",sans-serif;
mso-ligatures:standardcontextual;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#467886;
text-decoration:underline;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
mso-ligatures:none;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="en-DE" link="#467886" vlink="#96607D" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hello,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Is this a bug in QsciScintilla::annotation() (from qsciscintilla.cpp in version 2.14.1) ? The variable “buf” is never initialized with anything.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">// Get the annotation for a line, if any.<o:p></o:p></p>
<p class="MsoNormal">QString QsciScintilla::annotation(int line) const<o:p></o:p></p>
<p class="MsoNormal">{<o:p></o:p></p>
<p class="MsoNormal"> int size = SendScintilla(SCI_ANNOTATIONGETTEXT, line, (const char *)0);<o:p></o:p></p>
<p class="MsoNormal"> char *buf = new char[size + 1];<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"> QString qs = bytesAsText(buf, size);<o:p></o:p></p>
<p class="MsoNormal"> delete[] buf;<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"> return qs;<o:p></o:p></p>
<p class="MsoNormal">}<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I think there is a call for SendScintilla() missing: <o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">char *buf = new char[size + 1];<o:p></o:p></p>
<p class="MsoNormal">SendScintilla(SCI_ANNOTATIONGETTEXT, line, (char *)buf);<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Greetings,<o:p></o:p></p>
<p class="MsoNormal">Moritz<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<table class="MsoNormalTable" border="0" cellspacing="0" cellpadding="0" summary="Email signature" width="100%" style="width:100.0%;border-collapse:collapse">
<tbody>
<tr>
<td width="100%" style="width:100.0%;padding:0cm 0cm 0cm 0cm">
<div id="signature">
<div style="margin-bottom:15.0pt">
<p class="MsoNormal" style="margin-top:27.0pt;line-height:12.0pt"><span style="font-size:9.0pt;font-family:"Verdana",sans-serif;color:black;mso-ligatures:none;mso-fareast-language:#2000"><img width="87" height="33" style="width:.9083in;height:.3416in" id="Picture_x0020_0" src="cid:image001.png@01DCB6B8.38F17C20" alt="ABB logotype"></span><span style="font-size:9.0pt;font-family:"Verdana",sans-serif;color:black;mso-ligatures:none;mso-fareast-language:#2000"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:15.0pt;line-height:12.0pt"><b><span style="font-size:9.0pt;font-family:"Verdana",sans-serif;color:#FF000F;mso-ligatures:none;mso-fareast-language:#2000">—</span></b><span style="font-size:9.0pt;font-family:"Verdana",sans-serif;color:#FF000F;mso-ligatures:none;mso-fareast-language:#2000"><o:p></o:p></span></p>
<div>
<p class="MsoNormal" style="line-height:12.0pt"><b><span style="font-size:9.0pt;font-family:"Verdana",sans-serif;color:black;mso-ligatures:none;mso-fareast-language:#2000">Moritz Wenk</span></b><span style="font-size:9.0pt;font-family:"Verdana",sans-serif;color:black;mso-ligatures:none;mso-fareast-language:#2000"><br>
PA-PCP – APROL – R&D Engineer <o:p></o:p></span></p>
</div>
<div style="margin-top:9.0pt">
<p class="MsoNormal" style="line-height:12.0pt"><b><span lang="DE" style="font-size:9.0pt;font-family:"Verdana",sans-serif;color:black;mso-ligatures:none;mso-fareast-language:#2000">ABB AG</span></b><span lang="DE" style="font-size:9.0pt;font-family:"Verdana",sans-serif;color:black;mso-ligatures:none;mso-fareast-language:#2000"><br>
An der Reichsbank 8<br>
44127 Essen<br>
Phone: +49 201 56577 100<br>
E-mail: </span><span style="font-size:9.0pt;font-family:"Verdana",sans-serif;color:black;mso-ligatures:none;mso-fareast-language:#2000"><a href="mailto:moritz.wenk@de.abb.com"><span lang="DE" style="color:black;text-decoration:none">moritz.wenk@de.abb.com</span></a></span><span lang="DE" style="font-size:9.0pt;font-family:"Verdana",sans-serif;color:black;mso-ligatures:none;mso-fareast-language:#2000"><br>
</span><span style="font-size:9.0pt;font-family:"Verdana",sans-serif;color:black;mso-ligatures:none;mso-fareast-language:#2000"><a href="https://www.abb.com/"><span lang="DE" style="color:darkgray;text-decoration:none">abb.com</span></a>
</span><span lang="DE" style="font-size:9.0pt;font-family:"Verdana",sans-serif;color:black;mso-ligatures:none;mso-fareast-language:#2000"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-top:18.0pt;line-height:12.0pt"><span style="font-size:9.0pt;font-family:"Verdana",sans-serif;color:black;mso-ligatures:none;mso-fareast-language:#2000"><img border="0" width="119" height="28" style="width:1.2416in;height:.2916in" id="Picture_x0020_1" src="cid:image002.png@01DCB6B8.38F17C20" alt="ABB logotype"></span><span style="font-size:9.0pt;font-family:"Verdana",sans-serif;color:black;mso-ligatures:none;mso-fareast-language:#2000"><o:p></o:p></span></p>
</div>
</div>
</div>
<div id="disclaimer">
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="DE" style="font-size:8.0pt;font-family:"Verdana",sans-serif;color:gray;mso-ligatures:none;mso-fareast-language:#2000">ABB AG<br>
Sitz/Head Office: Mannheim<br>
Registergericht/Registry Court: Mannheim<br>
Handelsregisternummer/Commercial Register No.: HRB 4664<br>
Vorstand/Managing Board: Klaus Eble (Vorsitzender/Chairman), Alexander Zumkeller<br>
Vorsitzender des Aufsichtsrats/ Chairman of Supervisory Board: Adrian Guggisberg<br>
<br>
Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren
sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet.<br>
Bitte beachten Sie auch unsere Datenschutzerklärung, die Sie auf unserer </span><span style="font-size:8.0pt;font-family:"Verdana",sans-serif;color:gray;mso-ligatures:none;mso-fareast-language:#2000"><a href="https://new.abb.com/privacy-policy/de/datenschutz" target="_blank"><span lang="DE" style="color:blue">Webseite</span></a>
</span><span lang="DE" style="font-size:8.0pt;font-family:"Verdana",sans-serif;color:gray;mso-ligatures:none;mso-fareast-language:#2000">finden.<br>
<br>
</span><span style="font-size:8.0pt;font-family:"Verdana",sans-serif;color:gray;mso-ligatures:none;mso-fareast-language:#2000">This E-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this E-mail
in error) please notify the sender immediately and destroy this E-mail. Any unauthorized copying, disclosure or distribution of the material in this E-mail is strictly forbidden.<br>
Please also take note of our privacy notice, which you can find on our <a href="https://new.abb.com/privacy-notice" target="_blank">
<span style="color:blue">webpage</span></a>. </span><span style="mso-ligatures:none;mso-fareast-language:#2000"><o:p></o:p></span></p>
</div>
</td>
</tr>
</tbody>
</table>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>