[QScintilla] [PATCH] Sort input file list

Bernhard M. Wiedemann bwiedemann at suse.de
Wed Nov 7 20:26:07 GMT 2018


Sort input file list
so that Qsci.so builds in a reproducible way
in spite of indeterministic filesystem readdir order

See https://reproducible-builds.org/ for why this is good.

Without this patch, openSUSE's python-qscintilla-qt5 package
varied for every build.
On this topic: https://bugzilla.opensuse.org/show_bug.cgi?id=1041090

Index: QScintilla_gpl-2.10/Python/configure.py
===================================================================
--- QScintilla_gpl-2.10.orig/Python/configure.py
+++ QScintilla_gpl-2.10/Python/configure.py
@@ -1544,7 +1544,7 @@ macx {
     pro.write('HEADERS = sipAPI%s.h\n' % mname)
 
     pro.write('SOURCES =')
-    for s in os.listdir(module_config.name):
+    for s in sorted(os.listdir(module_config.name)):
         if s.endswith('.cpp'):
             pro.write(' \\\n    %s' % s)
     pro.write('\n')


More information about the QScintilla mailing list