[QScintilla] QScintilla 2.8

[Hans-Peter Jansen]

Dear Phil,

since this issue is still present, I kindly ask you for looking into it.
As written, the patches solve other issues, but this one stopped me.

On Mittwoch, 18. Dezember 2013 23:48:59 Hans-Peter Jansen wrote:
> Hi Phil,
> 
> in an attempt to build QScintilla 2.8 in the usual way¹, I noticed some
> issues. I was able to fix some of them with the attached patches, but
> failed on this one:
> 
> [   58s] g++ -c -pipe -fmessage-length=0 -grecord-gcc-switches -O2 -Wall
> -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables
> -fasynchronous-unwind-tables -g -DUSE_LIB64_PATHES -fno-strict-aliasing -w
> -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2
> -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g
> -DUSE_LIB64_PATHES -fno-strict-aliasing -D_REENTRANT -fPIC 
> -DQSCINTILLA_MAKE_DLL -DSCINTILLA_QT -DSCI_LEXER -DQT_NO_DEBUG
> -DQT_THREAD_SUPPORT -DQT_SHARED -DQT_TABLET_SUPPORT
> -I/usr/lib/qt3/mkspecs/default -I. -I. -I../include -I../lexlib -I../src
> -I/usr/include -I/usr/lib/qt3/include -o LexAPDL.o ../lexers/LexAPDL.cpp [ 
>  58s] In file included from ScintillaQt.h:64:0,
> [   58s]                  from ScintillaQt.cpp:38:
> [   58s] ../src/Editor.h: In member function 'QString
> QsciScintillaQt::textRange(const SelectionText*) const': [   58s]
> ../src/Editor.h:81:14: error: 'std::string SelectionText::s' is private [  
> 58s]   std::string s;
> [   58s]               ^
> [   58s] ScintillaQt.cpp:425:16: error: within this context
> [   58s]      if (!text->s)
> [   58s]                 ^
> [   58s] ScintillaQt.cpp:425:9: error: no match for 'operator!' (operand
> type is 'const string {aka const std::basic_string<char>}') [   58s]     
> if (!text->s)
> [   58s]          ^
> [   58s] ScintillaQt.cpp:425:9: note: candidate is:
> [   58s] ScintillaQt.cpp:425:9: note: operator!(bool) <built-in>
> [   58s] ScintillaQt.cpp:425:9: note:   no known conversion for argument 1
> from 'const string {aka const std::basic_string<char>}' to 'bool' [   58s]
> make: *** [ScintillaQt.o] Error 1

Full build log:

https://build.opensuse.org/package/live_build_log/home:frispete:PyQt/qscintilla/openSUSE_13.1/x86_64

Build spec:

https://build.opensuse.org/package/view_file/home:frispete:PyQt/qscintilla/qscintilla.spec?expand=1

TIA,
Pete

> It might bail on some other lexer, though.
> 
> Any idea?
> 
> BTW: it would be nice to NOT abandon the Qt3 builds right away, please ;-)..
> 
> Thanks & cheers,
> Pete
> 
> 
> ¹)
> https://build.opensuse.org/package/live_build_log/home:frispete:PyQt/qscinti
> lla/openSUSE_13.1/i586