[PyQt] -a option of configure.py in PyQt-x11-gpl-4-snapshot-20070709 broken

[Phil Thompson]

On Tuesday 10 July 2007 12:30 pm, Giovanni Bajo wrote:
> On 7/10/2007 5:59 AM, Gerard Vermeulen wrote:
> > $ echo "yes" | python configure.py -a
> > Determining the layout of your Qt installation...
> > This is the GPL version of PyQt 4-snapshot-20070709 (licensed under the
> > GNU General Public License) for Python 2.5.1 on linux2.
> >
> > [ ...]
> >
> > Traceback (most recent call last):
> >   File "configure.py", line 1733, in <module>
> >     main(sys.argv)
> >   File "configure.py", line 1696, in main
> >     inform_user()
> >   File "configure.py", line 720, in inform_user
> >     sipconfig.inform("The QScintilla API file will be installed in %s."
> > % os.path.join(opts.qscidir, "api", "python")) File
> > "/home/packer/usr/lib/python2.5/posixpath.py", line 62, in join elif
> > path == '' or path.endswith('/'): AttributeError: 'NoneType' object has
> > no attribute 'endswith'
>
> -a/--qsci-api basically means: "install QScintilla API to the default
> directory". You need -n/--qsci-api-destdir to specify a custom directory.
>
> But: the code that computes the default directory is currently disabled.
> See this FIXME around line 1664:
>
>      if opts.qscidir:
>          # An explicit directory implies installing the API file.
>          opts.api = 1
>      elif False: # FIXME the path is not always writable!
>          opts.qscidir = os.path.join(qt_datadir, "qsci")
>
>          if os.path.isdir(opts.qscidir):
>              # Install the API file if the default directory exists.
>              opts.api = 1
>
> So I don't think this is a regression introduced by my patch to add long
> options. It was probably broken before.
>
> Phil?

You introduced the FIXME if that's the question. I've reverted it.

Phil